Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update batch group stats to be by len(b.Points) #605

Merged
merged 2 commits into from
Jun 3, 2016

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented Jun 3, 2016

So there are several stats that Kapacitor keeps track of, and they have different uses.

  1. Every edge has an emitted/collected counters. These are the stats printed in the kapacitor show command under processed.
  2. Every edge has emitted/collected counters for each group of the source node. These are the stats used for deadman's switch aka the StatsNode.

Depending on the edge type the counters count different things.

For Stream edges its simple. The counters always count the number of points emitted or collected.

For batch its different. You can count the number of batches or the number of points in each batch. Both counts are important as such this PR changes the behavior so we can capture both values.

Above first counters count the number of batches the edge has processed. The second counters by group count the number of points per batch. Which if an empty batch is emitted means the counter will not increase. (NOTE: empty batches are preserved now from where filters etc, but still not produced from QueryNodes , see #595)

In summary if the StatsNode will report the number of points processed for each group independent of edge type. The basic edge counters report number of points for stream and number of batches for batch edges.

This change makes it so you can consume the StatsNode consistently independent of edge type.

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@nathanielc nathanielc merged commit c10f499 into master Jun 3, 2016
@nathanielc nathanielc deleted the nc-emitted-batch-counts branch June 3, 2016 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant